-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dashboard table view #6015
Add dashboard table view #6015
Conversation
…-auth-authorization-app
wip/pb/cognito-auth-authorization-app
…-auth-authorization-app
for posterity (since new commits have changed line numbers): enso/app/ide-desktop/lib/content/src/index.ts Line 148 in 3de3aab
enso/app/ide-desktop/lib/content/src/index.ts Lines 167 to 169 in 3de3aab
|
@@ -150,4 +158,4 @@ | |||
} | |||
} | |||
} | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no nl
@@ -40,7 +40,7 @@ | |||
<script type="module" src="/run.js" defer></script> | |||
</head> | |||
<body> | |||
<div id="dashboard"></div> | |||
<div id="dashboard" class="dashboard"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we change id and class to enso-dashboard
? then we probably need also update prefix in tailwindcss
@@ -13,13 +13,9 @@ const ESBUILD_PATH = '/esbuild' | |||
const ESBUILD_EVENT_NAME = 'change' | |||
|
|||
// =================== | |||
// === Live reload === | |||
// === Live relaod === |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reload
Thanks for the flags. Please address comments and open for review |
@PabloBuchu can't repro, sorry - logs show that the project manager is being started:
(did a fresh rebuild just to double-check) |
@somebody1234 so one minor issue: listing projects from project_manager works fine, but clicking on open project calls for API. We could leave it for now and fix it in #5804 this PR |
@PabloBuchu login templates? |
@somebody1234 |
@PabloBuchu a bit late but i pushed a commit that should fix it |
@somebody1234 did you pushed your latest changes? Because I still can't get to work cloud flags properly
Screen.Recording.2023-04-13.at.10.59.26.mov
Uploading Screen Recording 2023-04-13 at 11.00.53.mov…
Screen.Recording.2023-04-13.at.11.02.21.mov |
whoops :| |
Thanks works now. QA:
@wdanilo can you please take a look and review the code? |
logger: loggerProvider.Logger | ||
platform: platformModule.Platform | ||
/** Whether the dashboard should be rendered. */ | ||
enableDashboard: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor thing, but I think showDashboard
would be a better name. enableDashboard
makes me confused what "enabling" it really means, while, according to docs, this is only about showing it.
Pull Request Description
Important Notes
To do:
Screenshots
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.