-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data cleanse component #9879
Conversation
9e285f9
to
8bcde0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I'd prefer to move the Text
type tests to Base_Tests
as testing them as part of in-memory Table implementation feels weird.
would we perhaps want a although it probably wouldn't be too late to only add that only when someone actually has a usecase for it... |
So operator78170.replace (regex "\d") ' ' exists today. But do you mean the ability to use our named regexs in replace? That is an interesting idea... |
I understood as ability for the regex to replace the number not with empty But I'm writing because this also struck a chord with me - I was thinking that with this method when cleaning e.g. But essentially this stems the idea if maybe we should be able to control if the cleansing should "preserve separation between words". I.e. by default we replace everything with But it feels like this is complicating this rather simple tool, so maybe that is not really what we want at this stage for this component. Just throwing ideas around. |
whoops my bad, i meant |
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso
Outdated
Show resolved
Hide resolved
50cbf96
to
ff9f778
Compare
Pull Request Description
Add new cleanse and text_cleanse components
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.