Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix issues with checking PRs created against repository forks #9926

Merged
merged 5 commits into from May 14, 2024

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented May 11, 2024

Pull Request Description

This PR fixes several issues that were appearing when running CI jobs on PRs created against the repository forks:

  • electron-builder on Windows and macOS will properly recognize that the secrets are missing and will not attempt to sign the artifacts;
  • similarly, fixed the S3 library tests;
  • test reporter step will be now skipped, as it does not support forks.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@mwu-tow mwu-tow added the CI: No changelog needed Do not require a changelog entry for this PR. label May 11, 2024
@mwu-tow mwu-tow self-assigned this May 11, 2024
@mwu-tow mwu-tow marked this pull request as ready for review May 13, 2024 12:36
@mwu-tow mwu-tow requested review from kazcw and vitvakatu May 13, 2024 12:36
@mwu-tow mwu-tow added the CI: Ready to merge This PR is eligible for automatic merge label May 14, 2024
@mergify mergify bot merged commit 7982935 into enso-org:develop May 14, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants