entproto/cmd/protoc-gen-entgrpc - infra for gRPC field validation #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8m
reviewed
Apr 1, 2021
|
Please use "squash and merge" when you land this and replace the Great work, and thanks for adding this 🙏 |
rotemtam
force-pushed
the
feat/entgrpc-validation-infra
branch
from
9d8be96
to
d654d65
Compare
rotemtam
changed the title
a8m
approved these changes
Apr 4, 2021
Comment on lines
88
to
100
| checkIDFlag := "true" | ||
| if op == "create" { | ||
| checkIDFlag = "false" | ||
| } | ||
|
|
||
| if typeNeedsValidator(g.fieldMap) { | ||
| g.Tmpl(`if err := validate%(typeName)(%(reqVar), %(checkIDFlag)); err != nil { | ||
| return nil, %(statusErrf)(%(invalidArgument), "invalid argument: %s", err) | ||
| }`, g.withGlobals(tmplValues{ | ||
| "reqVar": reqVar, | ||
| "checkIDFlag": checkIDFlag, | ||
| })) | ||
| } |
There was a problem hiding this comment.
Suggested change
| checkIDFlag := "true" | |
| if op == "create" { | |
| checkIDFlag = "false" | |
| } | |
| if typeNeedsValidator(g.fieldMap) { | |
| g.Tmpl(`if err := validate%(typeName)(%(reqVar), %(checkIDFlag)); err != nil { | |
| return nil, %(statusErrf)(%(invalidArgument), "invalid argument: %s", err) | |
| }`, g.withGlobals(tmplValues{ | |
| "reqVar": reqVar, | |
| "checkIDFlag": checkIDFlag, | |
| })) | |
| } | |
| if typeNeedsValidator(g.fieldMap) { | |
| g.Tmpl(`if err := validate%(typeName)(%(reqVar), %(checkIDFlag)); err != nil { | |
| return nil, %(statusErrf)(%(invalidArgument), "invalid argument: %s", err) | |
| }`, g.withGlobals(tmplValues{ | |
| "reqVar": reqVar, | |
| "checkIDFlag": strconv.FormatBool(op == "create"), | |
| })) | |
| } |
Comment on lines
33
to
36
| if d.IsEdgeField { | ||
| return d.EdgeIDType() == field.TypeUUID | ||
| } | ||
| return d.EntField.IsUUID() |
There was a problem hiding this comment.
Do you use the EdgeIDType method only here? Maybe you can do instead:
Suggested change
| if d.IsEdgeField { | |
| return d.EdgeIDType() == field.TypeUUID | |
| } | |
| return d.EntField.IsUUID() | |
| f := d.EntField | |
| if d.IsEdgeField { | |
| f = d.EntEdge.Type.ID | |
| } | |
| return f.IsUUID() |
| res, err := svc.client.User.Create(). | ||
| SetBanned(bool(user.GetBanned())). | ||
| SetCrmID(runtime.MustBytesToUUID(user.GetCrmId())). |
There was a problem hiding this comment.
Do you prefer to panic here instead of returning an error? Maybe it is worth mentioning this in the doc.
There was a problem hiding this comment.
It is guaranteed not to panic b/c a program that reaches here passed the validation code. In one of the next versions I will remove this "setter chain" and treat each field separately for supporting per field nullability etc. In that PR it might be easy to make it nicer as you suggest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding infra for validation on the gRPC layer + UUID field support (normal field, edge id, id)
Fixes ent/ent#1402