Turn on prefetch task and enable hermetic builds #1555
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1555 +/- ##
=======================================
Coverage 80.71% 80.71%
=======================================
Files 66 66
Lines 4813 4813
=======================================
Hits 3885 3885
Misses 928 928
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Build pipeline still shows prefetch being skipped, so this patch is not sufficient.. |
simonbaird
force-pushed
the
try-hermetic-build-in-main-ci
branch
from
fb13bf4
to
22b0554
Compare
|
I was tricked by the key ordering. Also I didn't understand what Pushed a new revision. |
There was a problem hiding this comment.
Would it make sense to use the cosign binary from the RHTAS cosign image?
|
Pushed a POC DNM commit to use the downstream cosign image to get a copy of the cosign binary. |
simonbaird
force-pushed
the
try-hermetic-build-in-main-ci
branch
from
0fd35bf
to
3971134
Compare
|
Currently still fails on the |
This will fail because we are still doing a curl fetch of cosign and some microdnf install. Ref: https://issues.redhat.com/browse/EC-360
simonbaird
force-pushed
the
try-hermetic-build-in-main-ci
branch
from
3971134
to
9fc77e3
Compare
| @@ -82,8 +99,10 @@ LABEL \ | |||
| com.redhat.component="ec-cli" | |||
|
|
|||
| # Install cosign and other tools we want to use in the Tekton task | |||
| # Todo: How to prefetch these rpms in the prefetch-dependencies task?? | |||
Not sure if this will work, but let's try it.
Ref: https://issues.redhat.com/browse/EC-360