Use /usr/local/bin for container build ec binary #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems tidier to put it there rather than in /usr/bin with many other base image binaries. Also it's consistent with the Red Hat Konflux image build. Ref: https://issues.redhat.com/browse/EC-642
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1628 +/- ##
==========================================
+ Coverage 80.70% 87.25% +6.55%
==========================================
Files 64 75 +11
Lines 4705 5045 +340
==========================================
+ Hits 3797 4402 +605
+ Misses 908 643 -265
Flags with carried forward coverage won't be shown. Click here to find out more. |
lcarva
approved these changes
May 16, 2024
robnester-rh
approved these changes
May 16, 2024
simonbaird
added a commit
to simonbaird/infra-deployments
that referenced
this pull request
May 30, 2024
The ec binary is now in /usr/local/bin instead of /usr/bin. This change happened in enterprise-contract/ec-cli#1628 This should fix a legitmate e2e test failure in redhat-appstudio#3746
simonbaird
added a commit
to simonbaird/infra-deployments
that referenced
this pull request
May 30, 2024
The ec binary is now in /usr/local/bin instead of /usr/bin, which was changed in enterprise-contract/ec-cli#1628 This should fix a legitimate e2e test failure in redhat-appstudio#3746
rhtap-qe-bots-2
pushed a commit
to redhat-appstudio-qe/infra-deployments
that referenced
this pull request
Jun 4, 2024
The ec binary is now in /usr/local/bin instead of /usr/bin, which was changed in enterprise-contract/ec-cli#1628 This should fix a legitimate e2e test failure in redhat-appstudio#3746
rhtap-qe-bots
pushed a commit
to redhat-appstudio-qe/infra-deployments
that referenced
this pull request
Jun 4, 2024
The ec binary is now in /usr/local/bin instead of /usr/bin, which was changed in enterprise-contract/ec-cli#1628 This should fix a legitimate e2e test failure in redhat-appstudio#3746
rhtap-qe-bots-2
pushed a commit
to redhat-appstudio-qe/infra-deployments
that referenced
this pull request
Jun 4, 2024
The ec binary is now in /usr/local/bin instead of /usr/bin, which was changed in enterprise-contract/ec-cli#1628 This should fix a legitimate e2e test failure in redhat-appstudio#3746
redhat-appstudio-qe-bot
pushed a commit
to redhat-appstudio-qe/infra-deployments
that referenced
this pull request
Jun 4, 2024
The ec binary is now in /usr/local/bin instead of /usr/bin, which was changed in enterprise-contract/ec-cli#1628 This should fix a legitimate e2e test failure in redhat-appstudio#3746
redhat-appstudio-qe-bot
pushed a commit
to redhat-appstudio-qe/infra-deployments
that referenced
this pull request
Jun 4, 2024
The ec binary is now in /usr/local/bin instead of /usr/bin, which was changed in enterprise-contract/ec-cli#1628 This should fix a legitimate e2e test failure in redhat-appstudio#3746
openshift-merge-bot bot
pushed a commit
to redhat-appstudio/infra-deployments
that referenced
this pull request
Jun 4, 2024
* Update path to ec binary in download service The ec binary is now in /usr/local/bin instead of /usr/bin, which was changed in enterprise-contract/ec-cli#1628 This should fix a legitimate e2e test failure in #3746 * enterprise contract update (Cherry-picked from the commit in #3746) --------- Co-authored-by: ec-automation[bot] <32872589-ec-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems tidier to put it there rather than in /usr/bin with many other base image binaries. Also it's consistent with the Red Hat Konflux image build.
Ref: https://issues.redhat.com/browse/EC-642