fix: missing required files should count as an error #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbruch
reviewed
Apr 25, 2024
| @@ -110,6 +110,9 @@ public void validateMissingFile(FileValidationResult fvr) { | |||
| fvr.setVersion(version.getVersionString()); | |||
| fvr.setSchema(version.getSchema(fvr.getFile()).toString()); | |||
| fvr.setRequired(version.isFileRequired(fvr.getFile())); | |||
| if (version.isFileRequired(fvr.getFile())) { | |||
There was a problem hiding this comment.
Is a file only required, if the spec requires it, or also if it is announced in the discoveryFile (alias gbfs.json)?
There was a problem hiding this comment.
In this case, if the spec requires it. Missing files announced in discovery file is not considered. Maybe it should be an error on the discovery file?
There was a problem hiding this comment.
I'm merging this as is, can we handle the other case in a separate issue?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.