Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make select element ids distinct #574

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: make select element ids distinct #574

wants to merge 2 commits into from

Conversation

armichaud
Copy link

@armichaud armichaud commented Aug 8, 2023 •
edited

Description

Renamed ID for navigation tabs.

Fixes #547

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Loaded platform app in dev environment, validated that the ID for the select element was

Test Configuration:

  • OS with version: MacOS Ventura 13.4
  • Browser with version: Chrome 115.0.5790.114
  • SDK / CLI with version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I documented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@armichaud armichaud mentioned this pull request Aug 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: duplicate form field in the same form
1 participant
@armichaud