Skip to content

Commit

Permalink
[envoy] Remove max limit for endpoint/locality weight (#7437)
Browse files Browse the repository at this point in the history
Signed-off-by: Ruslan Nigmatullin <elessar@dropbox.com>

Mirrored from https://github.com/envoyproxy/envoy @ 1e39e303fe0bcf5695d89841df08d5cb223d3879
  • Loading branch information
data-plane-api(CircleCI) committed Jul 2, 2019
1 parent 2bcd30b commit 965c278
Showing 1 changed file with 5 additions and 19 deletions.
24 changes: 5 additions & 19 deletions envoy/api/v2/endpoint/endpoint.proto
Expand Up @@ -74,22 +74,15 @@ message LbEndpoint {
// to subset the endpoints considered in cluster load balancing.
core.Metadata metadata = 3;

// The optional load balancing weight of the upstream host, in the range 1 -
// 128. Envoy uses the load balancing weight in some of the built in load
// The optional load balancing weight of the upstream host; at least 1.
// Envoy uses the load balancing weight in some of the built in load
// balancers. The load balancing weight for an endpoint is divided by the sum
// of the weights of all endpoints in the endpoint's locality to produce a
// percentage of traffic for the endpoint. This percentage is then further
// weighted by the endpoint's locality's load balancing weight from
// LocalityLbEndpoints. If unspecified, each host is presumed to have equal
// weight in a locality.
//
// .. attention::
//
// The limit of 128 is somewhat arbitrary, but is applied due to performance
// concerns with the current implementation and can be removed when
// `this issue <https://github.com/envoyproxy/envoy/issues/1285>`_ is fixed.
google.protobuf.UInt32Value load_balancing_weight = 4
[(validate.rules).uint32 = {gte: 1, lte: 128}];
google.protobuf.UInt32Value load_balancing_weight = 4 [(validate.rules).uint32 = {gte: 1}];
}

// A group of endpoints belonging to a Locality.
Expand All @@ -103,7 +96,7 @@ message LocalityLbEndpoints {
// The group of endpoints belonging to the locality specified.
repeated LbEndpoint lb_endpoints = 2 [(gogoproto.nullable) = false];

// Optional: Per priority/region/zone/sub_zone weight - range 1-128. The load
// Optional: Per priority/region/zone/sub_zone weight; at least 1. The load
// balancing weight for a locality is divided by the sum of the weights of all
// localities at the same priority level to produce the effective percentage
// of traffic for the locality.
Expand All @@ -113,14 +106,7 @@ message LocalityLbEndpoints {
// configured. These weights are ignored otherwise. If no weights are
// specified when locality weighted load balancing is enabled, the locality is
// assigned no load.
//
// .. attention::
//
// The limit of 128 is somewhat arbitrary, but is applied due to performance
// concerns with the current implementation and can be removed when
// `this issue <https://github.com/envoyproxy/envoy/issues/1285>`_ is fixed.
google.protobuf.UInt32Value load_balancing_weight = 3
[(validate.rules).uint32 = {gte: 1, lte: 128}];
google.protobuf.UInt32Value load_balancing_weight = 3 [(validate.rules).uint32 = {gte: 1}];

// Optional: the priority for this LocalityLbEndpoints. If unspecified this will
// default to the highest priority (0).
Expand Down

0 comments on commit 965c278

Please sign in to comment.