core: apply protobuf patch to prevent duplicate symbols #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Rebello <me@michaelrebello.com>
keith
reviewed
Dec 31, 2019
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
keith
approved these changes
Dec 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #617, which resulted in duplicate symbols from protobuf being present in the final Envoy Mobile binary.
The root cause is being patched in Bazel. In the meantime, we can revert these two commits in protobuf (first, second) and apply the diff as a patch until we're able to update Bazel with the fix. More context on the protobuf issue is available here.
Notes:
http_archiveshould be in lockstep with upstream Envoy's version@envoy//bazel:protobuf.patchpatch is also included hereSigned-off-by: Michael Rebello me@michaelrebello.com