New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gzip: drop deprecated filter #15867
gzip: drop deprecated filter #15867
Conversation
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
I guess this PR should wait until API v2 is completely dropped to make the API check pass. |
@rojkov you can't delete protos from the APIs, even after the v2 turndown. But you can remove proxy-side support. |
@htuch I put all the protos back (v2 and v3), but now protodoc is failing when I run Should I put an empty |
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
…te-v4 Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
@phlax Thanks! No hurry, it's a tech debt PR. |
…te-v4 Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
im not sure exactly how best to keep the proto files around but not include them (mho is that they should be removed as historical versions of the repo still contain them) how they would be kept before they should be included is by adding a |
…te-v4 Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
ah wait i see - there is still a gzip extension - its just been removed from http.filters - ill check the pr again for compat |
@phlax gzip support (through the generic compressor filter) is still there. This PR removes the old gzip filter, deprecated long time ago. |
got it - thanks - seems like the pr should be gtm - ill merge it now |
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
@markdroth Could you please have a look? This PR seems to be ready for review. |
…te-v4 Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
/lgtm v2-freeze |
The HTTP Gzip filter has been disabled in v1.17 by default. Now we can remove it completely. Also the code common for the gzip filter and for the generic compressor filter is moved to source/extensions/filters/http/compressor. Risk Level: Low Testing: unit tests Docs Changes: removed the page about the Gzip filter Release Notes: added a note about the removal to current.rst Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
Commit Message: gzip: drop deprecated filter
Additional Description:
The HTTP Gzip filter has been disabled in v1.17 by default. Now we can remove it completely. Also the code common for the gzip filter and for the generic compressor filter is moved to
source/extensions/filters/http/compressor
.Risk Level: Low
Testing: unit tests
Docs Changes: removed the page about the Gzip filter
Release Notes: added a note about the removal to current.rst