Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Update xds_protocol doc to remove v2 and cleanup #16097

Merged
merged 2 commits into from Apr 24, 2021
Merged

api: Update xds_protocol doc to remove v2 and cleanup #16097

merged 2 commits into from Apr 24, 2021

Conversation

phlax
Copy link
Member

@phlax phlax commented Apr 21, 2021 •
edited

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: api: Update xds_protocol doc to remove v2 and cleanup
Additional Description:

Breakout PR from #16077

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft April 21, 2021 12:02
@phlax
Copy link
Member Author

phlax commented Apr 21, 2021

docs - https://storage.googleapis.com/envoy-pr/16097/docs/index.html

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Apr 23, 2021
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16097 was synchronize by phlax.

see: more, trace.

@phlax phlax force-pushed the api-no-v2-xds branch 2 times, most recently from fc208f6 to a2272ae Compare April 23, 2021 11:35
phlax
phlax commented Apr 23, 2021
View reviewed changes
api/xds_protocol.rst Outdated Show resolved Hide resolved
phlax
phlax commented Apr 23, 2021
View reviewed changes
api/xds_protocol.rst Outdated Show resolved Hide resolved
phlax
phlax commented Apr 23, 2021
View reviewed changes
api/xds_protocol.rst Outdated Show resolved Hide resolved
@phlax phlax marked this pull request as ready for review April 23, 2021 12:01
@phlax phlax changed the title [WIP] api: Update xds_protocol doc to remove v2 api: Update xds_protocol doc to remove v2 Apr 23, 2021
@phlax phlax requested a review from htuch April 23, 2021 12:01
@phlax
Copy link
Member Author

phlax commented Apr 23, 2021

@hutch this is a breakout PR (from #16077) to update the xds_proto.rst doc and some cleanups

there are some inline configs which are not quite correct - im not 100% of what they should be - comments left inline

@phlax phlax changed the title api: Update xds_protocol doc to remove v2 api: Update xds_protocol doc to remove v2 and cleanup Apr 23, 2021
phlax
phlax commented Apr 23, 2021
View reviewed changes
.azure-pipelines/pipelines.yml Outdated Show resolved Hide resolved
@phlax
api: Update xds_protocol doc to remove v2 and cleanup
dbc6da2 
Signed-off-by: Ryan Northey <ryan@synca.io>
htuch
htuch requested changes Apr 23, 2021
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM once comments resolved.
/wait

api/xds_protocol.rst Show resolved Hide resolved
api/xds_protocol.rst Outdated Show resolved Hide resolved
api/xds_protocol.rst Outdated Show resolved Hide resolved
@phlax
type_url
ca43536 
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax requested a review from htuch April 23, 2021 18:45
htuch
htuch approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@asraa asraa merged commit 7cd615c into envoyproxy:main Apr 24, 2021
@ericvn ericvn mentioned this pull request Apr 26, 2021
Merged
gokulnair pushed a commit to gokulnair/envoy that referenced this pull request May 6, 2021
@phlax
api: Update xds_protocol doc to remove v2 and cleanup (envoyproxy#16097)
35f35aa 
* api: Update xds_protocol doc to remove v2 and cleanup

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Gokul Nair <gnair@twitter.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htuch htuch htuch approved these changes

Assignees
No one assigned
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phlax @htuch @asraa