api: Fix generated_api_shadow BUILD #16330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <ryan@synca.io>
Merged
alyssawilk
approved these changes
May 5, 2021
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
Commit Message: api: Fix generated_api_shadow BUILD Additional Description: Some changes were made to the api/BUILD file in envoyproxy#16077 which were not propagated to generated_api_shadow this is also a possible reason that a dev reported an issue with ci formatting Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Gokul Nair <gnair@twitter.com>
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
Commit Message: api: Fix generated_api_shadow BUILD Additional Description: Some changes were made to the api/BUILD file in envoyproxy#16077 which were not propagated to generated_api_shadow this is also a possible reason that a dev reported an issue with ci formatting Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Gokul Nair <gnair@twitter.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: api: Fix generated_api_shadow BUILD
Additional Description:
Some changes were made to the api/BUILD file in #16077 which were not propagated to generated_api_shadow
this is also a possible reason that a dev reported an issue with ci formatting
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]