Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove custom intersphinx extension #18090

Merged
merged 1 commit into from Jan 18, 2022

Conversation

phlax
Copy link
Member

@phlax phlax commented Sep 12, 2021

Commit Message: docs: Remove custom intersphinx extension
Additional Description:

Testing upstream PR sphinx-doc/sphinx#9459 to see if we can remove the custom intersphinx extension and resolve #16181

this seems to work correctly, but will have to wait for (at least) sphinx 4.3.0

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18090 was opened by phlax.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 12, 2021
@phlax phlax marked this pull request as draft September 12, 2021 09:25
@phlax
Copy link
Member Author

phlax commented Sep 12, 2021

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 12, 2021
@phlax phlax added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels Oct 12, 2021
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [TESTING] docs: Remove custom intersphinx extension docs: Remove custom intersphinx extension Jan 17, 2022
@phlax phlax marked this pull request as ready for review January 17, 2022 10:54
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wh00t!

@phlax phlax merged commit fe43754 into envoyproxy:main Jan 18, 2022
joshperry pushed a commit to joshperry/envoy that referenced this pull request Feb 13, 2022
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Josh Perry <josh.perry@mx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove custom intersphinx module from docs/_ext
2 participants