bazel: workaround invalid nonnull warning in v8 #23765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since gcc 12 it seems there are some false positives around this warning. Upstream gcc reports: - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107252 - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100366 - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106199 We can't use `--per_file_copt` in this case because we build this in the host configuration bazelbuild/bazel#12406 Upstream v8 report: https://bugs.chromium.org/p/v8/issues/detail?id=13441 Fixes envoyproxy#23692 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
phlax
approved these changes
Oct 31, 2022
repokitteh-read-only
bot
removed
the
deps
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since gcc 12 it seems there are some false positives around this warning.
Upstream gcc reports:
We can't use
--per_file_coptin this case because we build this in the host configuration bazelbuild/bazel#12406Upstream v8 report: https://bugs.chromium.org/p/v8/issues/detail?id=13441
Fixes #23692
Signed-off-by: Keith Smiley keithbsmiley@gmail.com