Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile/ci: Improve mobile jobs #27404

Merged
merged 4 commits into from May 23, 2023
Merged

mobile/ci: Improve mobile jobs #27404

merged 4 commits into from May 23, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented May 15, 2023

Fix #24437

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax force-pushed the gh-wf-env branch 2 times, most recently from 2cf1156 to 03f03da Compare May 15, 2023 15:12
@phlax phlax changed the title mobile/ci: Add github env.yml for format ci [WIP] mobile/ci: Add github env.yml for format ci May 15, 2023
@phlax phlax marked this pull request as draft May 15, 2023 15:12
@phlax phlax force-pushed the gh-wf-env branch 16 times, most recently from 21b2455 to dee919a Compare May 15, 2023 19:42
@phlax phlax changed the title [WIP] mobile/ci: Add github env.yml for format ci [WIP] mobile/ci: Consolidate mobile jobs May 15, 2023
@phlax phlax changed the title [WIP] mobile/ci: Consolidate mobile jobs mobile/ci: Consolidate mobile jobs May 15, 2023
@phlax phlax marked this pull request as ready for review May 15, 2023 19:43
@phlax
Copy link
Member Author

phlax commented May 15, 2023

this will need some required job name changes before it can land

.github/workflows/mobile.yml Outdated Show resolved Hide resolved
@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #27404 (comment) was created by @phlax.

see: more, trace.

@phlax phlax force-pushed the gh-wf-env branch 2 times, most recently from c2ac50a to 9df2817 Compare May 17, 2023 11:40
@phlax
Copy link
Member Author

phlax commented May 17, 2023

 ERROR: The Build Event Protocol upload failed: All 4 retry attempts failed. DEADLINE_EXCEEDED: DEADLINE_EXCEEDED: deadline exceeded after 14.999889499s. [closed=[], open=[[buffered_nanos=47600, remote_addr=envoy.cluster.engflow.com/54.197.155.115:443]]] DEADLINE_EXCEEDED: DEADLINE_EXCEEDED: deadline exceeded after 14.999889499s. [closed=[], open=[[buffered_nanos=47600, remote_addr=envoy.cluster.engflow.com/54.197.155.115:443]]]

@phlax
Copy link
Member Author

phlax commented May 17, 2023

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #27404 (comment) was created by @phlax.

see: more, trace.

@phlax phlax force-pushed the gh-wf-env branch 2 times, most recently from 643c803 to 3e6ed35 Compare May 18, 2023 07:29
Signed-off-by: Ryan Northey <ryan@synca.io>
@alyssawilk
Copy link
Contributor

/wait unmerged and unsure of status

@phlax
Copy link
Member Author

phlax commented May 23, 2023

/wait unmerged

ill merge now ...

... and unsure of status

keen to land 8)

Signed-off-by: Ryan Northey <ryan@synca.io>
@alyssawilk
Copy link
Contributor

this still merges all the jobs so we can't retry tasks individually while other tasks are running?

@phlax
Copy link
Member Author

phlax commented May 23, 2023

this still merges all the jobs so we can't retry tasks individually while other tasks are running?

no - it runs each as a separate workflow - the difference is that it only checks what to run once per workflow

mobile/tools/what_to_run.sh Show resolved Hide resolved
mobile/tools/what_to_run.sh Show resolved Hide resolved
mobile/tools/what_to_run.sh Show resolved Hide resolved
phlax added 2 commits May 23, 2023 19:32
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented May 23, 2023

/retest mobile

1 similar comment
@phlax
Copy link
Member Author

phlax commented May 23, 2023

/retest mobile

@phlax
Copy link
Member Author

phlax commented May 23, 2023

//test/java/org/chromium/net:cronet_url_request_test                     FAILED in 7.8s

@phlax
Copy link
Member Author

phlax commented May 23, 2023

/retest mobile

for the same failure again

@phlax
Copy link
Member Author

phlax commented May 23, 2023

/retest mobile

@phlax phlax merged commit ab3cc1f into envoyproxy:main May 23, 2023
78 of 79 checks passed
reskin89 pushed a commit to reskin89/envoy that referenced this pull request Jul 11, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dont run (mobile) github actions (for required checks) if there is no need
3 participants