Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/examples: Improve CI config #28445

Merged
merged 1 commit into from Jul 18, 2023
Merged

ci/examples: Improve CI config #28445

merged 1 commit into from Jul 18, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Jul 17, 2023

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft July 17, 2023 15:40
@phlax phlax force-pushed the ci-verify-fetch branch 10 times, most recently from 243b777 to a66f1e7 Compare July 17, 2023 20:59
@phlax phlax changed the title [WIP] ci/examples: Factor out GCP downloads [WIP] ci/examples: Improve CI config Jul 17, 2023
@phlax phlax force-pushed the ci-verify-fetch branch 6 times, most recently from 1d427cb to e0e748b Compare July 18, 2023 05:38
@phlax phlax changed the title [WIP] ci/examples: Improve CI config ci/examples: Improve CI config Jul 18, 2023
@phlax phlax marked this pull request as ready for review July 18, 2023 05:38
wbpcode
wbpcode previously approved these changes Jul 18, 2023
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@phlax phlax enabled auto-merge (squash) July 18, 2023 06:33
@phlax
Copy link
Member Author

phlax commented Jul 18, 2023

@wbpcode i spotted an issue with one of the template vars that should be fixed

also flagging that when this lands it will fail initially as the workflow that azp triggers will have moved

#28459 should fix that, the only way to avoid this would have been to first copy the wf, and then change, and then remove old etc

@phlax phlax changed the title ci/examples: Improve CI config [WIP] ci/examples: Improve CI config Jul 18, 2023
@phlax phlax marked this pull request as draft July 18, 2023 08:01
auto-merge was automatically disabled July 18, 2023 08:01

Pull request was converted to draft

@phlax
Copy link
Member Author

phlax commented Jul 18, 2023

reWIPping while i test/fix

@phlax phlax changed the title [WIP] ci/examples: Improve CI config ci/examples: Improve CI config Jul 18, 2023
@phlax phlax marked this pull request as ready for review July 18, 2023 08:25
@phlax
Copy link
Member Author

phlax commented Jul 18, 2023

should be fixed

@phlax phlax force-pushed the ci-verify-fetch branch 4 times, most recently from fd746e4 to c0fbd74 Compare July 18, 2023 09:44
Signed-off-by: Ryan Northey <ryan@synca.io>
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@phlax phlax merged commit 19d52b8 into envoyproxy:main Jul 18, 2023
93 of 94 checks passed
phlax added a commit to phlax/envoy that referenced this pull request Jul 19, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit that referenced this pull request Jul 20, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants