Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP/bp/1.25] Kafka + deps #29172

Closed
wants to merge 4 commits into from
Closed

[WIP/bp/1.25] Kafka + deps #29172

wants to merge 4 commits into from

Conversation

phlax
Copy link
Member

@phlax phlax commented Aug 21, 2023

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Aug 21, 2023
@phlax phlax added this to the 1.25.10 milestone Aug 21, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @htuch

🐱

Caused by: #29172 was opened by phlax.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented Aug 21, 2023

@adamkotwasinski as the backport for 1.25 and 1.24 (#29171 ) were a bit more complicated i separated out to their own prs

@phlax
Copy link
Member Author

phlax commented Aug 21, 2023

/retest

@phlax
Copy link
Member Author

phlax commented Aug 21, 2023

/wait for #28665

@adamkotwasinski
Copy link
Contributor

LGTM 👍 as in #29171 (comment)

@adamkotwasinski @phlax
kafka: fetch request (envoyproxy#24606)
a6b1416 
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
@adamkotwasinski @phlax
kafka: fetch record converter (envoyproxy#25300)
684c3f2 
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
@adamkotwasinski @phlax
kafka: provide Fetch support, giving mesh-filter stateful consumer pr…
c5957f7 
…oxy (envoyproxy#25611)

Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
@adamkotwasinski @phlax
kafka: upgrade dependencies to 3.5.1 (envoyproxy#28932)
3f51ae9 
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
@RyanTheOptimist
Copy link
Contributor

Looks like clang-tidy is failing.
/wait

@adamkotwasinski
Copy link
Contributor

hey @phlax & @RyanTheOptimist - I think the easier way to solve that would be to backport just the Kafka stuff and not the feature (filter) stuff; IIRC there were some .cc changes too that's why it's harder to port.
So TLDR I'll take a look into backporting only the smaller piece - but in about 1 or 2 weeks (sorry kinda busy IRL right now). Is that ok?

@phlax
Copy link
Member Author

phlax commented Aug 29, 2023

So TLDR I'll take a look into backporting only the smaller piece - but in about 1 or 2 weeks (sorry kinda busy IRL right now). Is that ok?

that would be amazing @adamkotwasinski - thanks - theres no immediate rush

@phlax phlax changed the title [bp/1.25] Kafka + deps [WIP/bp/1.25] Kafka + deps Aug 29, 2023
@phlax phlax marked this pull request as draft August 29, 2023 09:10
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Sep 28, 2023
@phlax
Copy link
Member Author

phlax commented Sep 28, 2023

closing in favour of #29825

@phlax phlax closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

Assignees

@htuch htuch

@adamkotwasinski adamkotwasinski

Labels
deps Approval required for changes to Envoy's external dependencies stale stalebot believes this issue/PR has not been touched recently waiting
Projects
None yet
Milestone
1.25.10
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phlax @adamkotwasinski @RyanTheOptimist @htuch