async_client: add support for filter state #33772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows upstream filters used in an AsyncClient request to access the FilterState. Signed-off-by: Isabel Mccarten <imccarten@google.com>
kyessenov
reviewed
Apr 24, 2024
| auto filter_state = | ||
| std::make_shared<StreamInfo::FilterStateImpl>(StreamInfo::FilterState::LifeSpan::FilterChain); | ||
| filter_state->setData("test-filter", state_object, StreamInfo::FilterState::StateType::Mutable); | ||
| options.setFilterState(filter_state); |
There was a problem hiding this comment.
Is the idea that a client must explicitly set the filter state in-code? Or would it be something automatic for sidecalls like ext_authz?
There was a problem hiding this comment.
The idea is that the authors of individual filters would need to explicitly set the FilterState on an AsyncClient call if they want it in a similar way to how the DynamicMetadata is currently handled. I think this makes sense since whether or not it makes sense to apply the state/metadata from the main request to a side request may vary depending on the use case.
|
/assign yanavlasov |
|
imccarten1 is not allowed to assign users. |
yanavlasov
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Add support for FilterState to AsyncClient
Additional Description: This allows upstream filters used in an AsyncClient request to access the FilterState.
Risk Level: low
Testing: Updated unit tests.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a