[Do No Merge]test contrib build with fips #33786
Conversation
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
…nsion" This reverts commit 5c67fea. Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
| --config=compile-time-options \ | ||
| --define wasm=wasmtime \ | ||
| --define enable_logging=disabled \ | ||
| -c fastbuild \ | ||
| @envoy//source/exe:envoy-static \ | ||
| @envoy//contrib/exe:envoy-static \ |
There was a problem hiding this comment.
we kinda want the test with the 2 following conditions to compare:
- existing - ie
//source - proposed change - ie both
There was a problem hiding this comment.
ok, let me try to build those two in c-t-o
There was a problem hiding this comment.
cool - was wondering whether we would need to separate as you have done
the benefit of this is that we only need to run the ci once to get the timings, and can see exactly how long the contrib build takes
There was a problem hiding this comment.
I run two bazel cmds, suppose we can get the timings separately. Let me trigger the CI it seems the CI broken friday.
ci/do_ci.sh
Outdated
| @@ -463,11 +463,12 @@ case $CI_TARGET in | |||
| --define log_debug_assert_in_release=disabled | |||
| echo "Building binary with wasm=wasmtime... and logging disabled" | |||
| bazel build "${BAZEL_BUILD_OPTIONS[@]}" \ | |||
| --action_env=TEST=TEST \ | |||
There was a problem hiding this comment.
for any timed test runs TEST=TEST will need to be changed to eg TEST=TEST23
There was a problem hiding this comment.
seems this messed up the ICU build - was wondering whether setting TEST would be safe - probs make it something like ARBITRARY_TEST
There was a problem hiding this comment.
emm...yea, TEST may be used by something.
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
soulxu
force-pushed
the
test_contrib_fips_build
branch
from
d66c08b
to
994931b
Compare
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
|
I don't know why this failure https://dev.azure.com/cncf/envoy/_build/results?buildId=169058&view=logs&j=e969334a-0e55-5c18-ac96-8b546753391e&t=d2cfa5df-b334-5e06-ef04-7a1905627a50&l=114, let me try to build one by one |
it has increased the cache size, and now its running out of (tmpfs) space to load the cache |
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]