Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic proxy: expose the codec error to upper layer #33788

Merged

Conversation

wbpcode
Copy link
Member

@wbpcode wbpcode commented Apr 25, 2024

Commit Message: generic proxy: expose the codec error to upper layer
Additional Description:

This PR extend the interface of generic codec to expose error from codecs to upper layer. Than the upper layer could use the error message to generate meaningful log or local response.

Risk Level: low, contrib only change.
Testing: unit.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.

@wbpcode
Copy link
Member Author

wbpcode commented Apr 25, 2024

ping for blind approve for this contrib only change. @alyssawilk Thanks.

Signed-off-by: wbpcode <wbphub@live.com>
@wbpcode wbpcode merged commit 08f2ec0 into envoyproxy:main Apr 29, 2024
51 checks passed
@wbpcode wbpcode deleted the dev-codec-error-expose-to-generic-proxy branch April 29, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants