mobile: Remove support for YAML in the mobile APIs #33799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Beyad <abeyad@google.com>
abeyad
requested review from
RyanTheOptimist,
alyssawilk and
fredyw
as code owners
fredyw
changed the title
|
/wait on CI I think? |
|
yes, sorry, i'm still working on figuring out the QuicTestServerTest and put it on the backburner Friday for other stuff. I didn't realize this was assigned to you, let me reassign to myself until its ready |
Signed-off-by: Ali Beyad <abeyad@google.com>
Signed-off-by: Ali Beyad <abeyad@google.com>
Signed-off-by: Ali Beyad <abeyad@google.com>
|
/assign @fredyw |
|
It looks like the CI is still failing. |
fredyw
previously approved these changes
May 6, 2024
|
/retest |
fredyw
previously approved these changes
May 6, 2024
|
/retest |
fredyw
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this change, a new EngineBuilder
setUpstreamTlsSni()API was added for all the language bindings,so that the upstream TLS socket's SNI can be overridden for test servers where the cert is created with a particular
hostname but we don't access the server via that hostname (instead, we use local address and local port).