stream_info: Make some struct members private #34058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Beyad <abeyad@google.com>
|
Why close? I think this is a good fix. |
Hey @kyessenov thanks! I ran into some issues w/ the PR and wasn't sure when I would be able to get back to it, so closed it, but I just tried a fix so re-opening the PR now. |
|
@kyessenov ping |
kyessenov
reviewed
May 14, 2024
| absl::InlinedVector<ResponseFlag, 4> response_flags_{}; | ||
| bool health_check_request_{}; | ||
| Router::RouteConstSharedPtr route_; | ||
| envoy::config::core::v3::Metadata metadata_{}; | ||
| FilterStateSharedPtr filter_state_; | ||
|
|
||
| private: |
There was a problem hiding this comment.
Can we keep the order of the fields the same? This is a fairly common data structure and the layout would change if we re-order - possibly for worse.
There was a problem hiding this comment.
The tests have a size check which passed:
envoy/test/common/stream_info/stream_info_impl_test.cc
Lines 44 to 48 in c6b8553
Signed-off-by: Ali Beyad <abeyad@google.com>
kyessenov
approved these changes
May 15, 2024
|
/retest |
alyssawilk
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.