OTel Access Logger: support additional stat prefix #34091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
adisuissa
reviewed
May 10, 2024
There was a problem hiding this comment.
Thanks for adding new features.
I've left API-related comments. This change will also require a release note.
Assigning to Yan as code-owner.
/assign @yanavlasov
api/envoy/extensions/access_loggers/open_telemetry/v3/logs_service.proto
Show resolved
Hide resolved
api/envoy/extensions/access_loggers/open_telemetry/v3/logs_service.proto
Outdated
Show resolved
Hide resolved
api/envoy/extensions/access_loggers/open_telemetry/v3/logs_service.proto
Outdated
Show resolved
Hide resolved
|
I will review once #34072 is submitted. |
add custom stats prefix Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
DONE |
TAOXUY
changed the title
yanavlasov
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the API, this allows to distinguish emitted statistics between configured open telemetry access loggers in the logger chain. If empty, the default
access_logs.open_telemetry_access_log.will be used.It is based on #34072 so please review from the 4th commit.