TcpProxy::CombinedUpstream: Implement watermark functions #34098
+150
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
|
/assign @alyssawilk |
Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
alyssawilk
reviewed
May 14, 2024
| void onDecoderFilterAboveWriteBufferHighWatermark() override {} | ||
| void onDecoderFilterBelowWriteBufferLowWatermark() override {} | ||
| void onDecoderFilterAboveWriteBufferHighWatermark() override { | ||
| parent_->upstream_callbacks_->onAboveWriteBufferHighWatermark(); |
There was a problem hiding this comment.
Mind adding the e2e backup tests along with this change?
grep FlowControl test/integration/* has some examples
/wait
Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
| @@ -64,6 +65,9 @@ class StopIterationAndContinueFilter : public Http::PassThroughFilter { | |||
| if (end_stream) { | |||
| setEndStreamAndDecodeTimer(); | |||
| } | |||
| if (stop_and_buffer_) { | |||
| return Http::FilterDataStatus::StopIterationAndBuffer; | |||
There was a problem hiding this comment.
If this change is not added, assertion fails in tcp_proxy.cc
// The upstream should consume all of the data.
// Before there is an upstream the connection should be readDisabled. If the upstream is
// destroyed, there should be no further reads as well.
ASSERT(0 == data.length());
Why we dont need this assertion in HCM case and it is there only in tcp_proxy?
Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
This reverts commit 2196563. Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
This reverts commit 9b7bc61. Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
This reverts commit 148ca65. Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
This reverts commit 201f6b5. Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #32991
Commit Message: Implement watermark functions which was a TODO and some cleanup
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]