dependencies: update protobuf to 3.8.0

[asraa]

In addition to updating protobuf to 3.8.0, this PR also

1. Removes old protobuf patch now included in 3.8.0
2. Patches fix a UBSAN warnings. protocolbuffers/protobuf#6333 that fixes a UBSAN error in the protobuf library.
3. Patches protobuf's BUILD to depend on foreign_cc zlib

Risk level: low/medium
Testing: bazel test //test/...

[moderation]

With 3.8.0 changing the zlib handling again and your changes in this PR I'm wondering if zlib is required in bazel/repository_locations.bzl any more? https://github.com/envoyproxy/envoy/blob/master/bazel/repository_locations.bzl#L141-L148

[asraa]

With 3.8.0 changing the zlib handling again and your changes in this PR I'm wondering if zlib is required in bazel/repository_locations.bzl any more? https://github.com/envoyproxy/envoy/blob/master/bazel/repository_locations.bzl#L141-L148

Hm, I saw your comment in the bzl file. Is zlib required besides as a dependency for protobuf? If not, I think you're right, perhaps it's not needed and we can use protobuf_deps() instead.
https://github.com/protocolbuffers/protobuf/blob/master/protobuf_deps.bzl

[moderation]

Hm, I saw your comment in the bzl file. Is zlib required besides as a dependency for protobuf? If not, I think you're right, perhaps it's not needed and we can use protobuf_deps() instead.
https://github.com/protocolbuffers/protobuf/blob/master/protobuf_deps.bzl

I think that the compressor, decompressor and quiche use zlib.

• https://github.com/envoyproxy/envoy/blob/master/source/common/compressor/BUILD#L15
• https://github.com/envoyproxy/envoy/blob/master/source/common/decompressor/BUILD#L15
• https://github.com/envoyproxy/envoy/blob/master/bazel/external/quiche.BUILD#L1612

If it's possible to have these reference the zlib brought in for protobuf it would mean one less dependency to maintain but it would also wouldn't be as clear.

[htuch]

I think we should stick with our own zlib rather than anything from protobuf, since we might want to rev versions independently. Also, I think foreign_cc is a bit cleaner than the artisinal BUILD file in protobuf third_party.

[htuch]

@asraa the api CI failure looks like it's potentially related to this change, maybe the precision or handling of floats has somehow changed in protobuf? You might want to update the test.

[moderation]

Timed out on macOS network listener tests

//test/common/network:listener_impl_test                                TIMEOUT in 301.0s
  /private/var/tmp/_bazel_vsts/c4c3c293a43c83b45613c302d61e9e23/execroot/envoy/bazel-out/darwin-fastbuild/testlogs/test/common/network/listener_impl_test/test.log
//test/common/network:udp_listener_impl_test                            TIMEOUT in 301.2s
  /private/var/tmp/_bazel_vsts/c4c3c293a43c83b45613c302d61e9e23/execroot/envoy/bazel-out/darwin-fastbuild/testlogs/test/common/network/udp_listener_impl_test/test.log

Flake? We need to document the Azure test commands.

[repokitteh-read-only]

🤷‍♀️ nothing to rebuild.

🐱

Caused by: a #7510 (comment) was created by @moderation.

see: more, trace.

[moderation]

/azp run envoy-macos

[azure-pipelines]

Commenter does not have sufficient privileges for PR 7510 in repo envoyproxy/envoy

[htuch]

/azp run envoy-macos

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[moderation]

LGTM