New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add file resource provider for EG standalone mode #3159
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
… provider Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in today's meeting, I prefer to remove the EnvoyGatewayCustomProvider
and add a flat EnvoyGatewayFileProvider
(or a better name).
Custom is needed to allow for different resource and infra provider |
Add it later when a use case comes out? The File/Host Provider is not a custom provider, it's a known one. |
use case exists today - file resource provider and host infra provider to implement standalone case, running EG in a docker container or bare metal directly w/o any API server |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we plan on releasing this in v1.1.0 ?
cc @arkodg
yeah I'm a +1 for this, prioritizing other PRs right now, will get to this one soon |
Some tests will be added after the first round of reviews. |
What type of PR is this?
What this PR does / why we need it:
This PR implement two component for file resource provider: Notifier and ResourceStore.
Which issue(s) this PR fixes:
related #1393
There're some TODOs in this PR, tracked by #3213 #3207