Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add file resource provider for EG standalone mode #3159

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Apr 10, 2024

What type of PR is this?

What this PR does / why we need it:

This PR implement two component for file resource provider: Notifier and ResourceStore.

  • Notifier monitors paths(files or dirs) on host via fsnotify, and send Write/Remove event to ResourceStore
  • ResourceStore load and store resources according to the received event

Which issue(s) this PR fixes:

related #1393


There're some TODOs in this PR, tracked by #3213 #3207

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
… provider

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 marked this pull request as ready for review April 18, 2024 07:09
@shawnh2 shawnh2 requested a review from a team as a code owner April 18, 2024 07:09
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in today's meeting, I prefer to remove the EnvoyGatewayCustomProvider and add a flat EnvoyGatewayFileProvider(or a better name).

@arkodg
Copy link
Contributor

arkodg commented Apr 24, 2024

As discussed in today's meeting, I prefer to remove the EnvoyGatewayCustomProvider and add a flat EnvoyGatewayFileProvider(or a better name).

Custom is needed to allow for different resource and infra provider

@zhaohuabing
Copy link
Member

zhaohuabing commented Apr 24, 2024

As discussed in today's meeting, I prefer to remove the EnvoyGatewayCustomProvider and add a flat EnvoyGatewayFileProvider(or a better name).

Custom is needed to allow for different resource and infra provider

Add it later when a use case comes out? The File/Host Provider is not a custom provider, it's a known one.

@arkodg
Copy link
Contributor

arkodg commented Apr 24, 2024

As discussed in today's meeting, I prefer to remove the EnvoyGatewayCustomProvider and add a flat EnvoyGatewayFileProvider(or a better name).

Custom is needed to allow for different resource and infra provider

Add it later when a use case comes out? The File/Host Provider is not a custom provider, it's a known one.

use case exists today - file resource provider and host infra provider to implement standalone case, running EG in a docker container or bare metal directly w/o any API server

@Xunzhuo
Copy link
Member

Xunzhuo commented May 14, 2024

/retest

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan on releasing this in v1.1.0 ?

cc @arkodg

@arkodg
Copy link
Contributor

arkodg commented May 15, 2024

Do we plan on releasing this in v1.1.0 ?

cc @arkodg

yeah I'm a +1 for this, prioritizing other PRs right now, will get to this one soon

@shawnh2
Copy link
Contributor Author

shawnh2 commented May 16, 2024

Some tests will be added after the first round of reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants