chore: resolve protoc-gen-go-grpc vulnerability #3267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
shahar-h
force-pushed
the
GHSA-8r3f-844c-mc37
branch
from
3097222
to
6fa586e
Compare
arkodg
reviewed
Apr 24, 2024
tools/src/protoc-gen-go-grpc/go.mod
Outdated
| @@ -5,3 +5,8 @@ go 1.22.2 | |||
| require google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.3.0 | |||
|
|
|||
| require google.golang.org/protobuf v1.28.1 // indirect | |||
|
|
|||
| // Resolve GHSA-8r3f-844c-mc37. | |||
| // This is a temporary fix until the next release of google.golang.org/grpc/cmd/protoc-gen-go-grpc. | |||
There was a problem hiding this comment.
Shouldn't a manual go get fix this ?
There was a problem hiding this comment.
Yes, once a new google.golang.org/grpc/cmd/protoc-gen-go-grpc version is available.
|
/retest |
1 similar comment
|
/retest |
|
here's what I was suggesting |
This would also work but IMO using a replace directive is cleaner and more clear as you can see the original version and add a comment above the version override. |
|
/retest |
It also introduces tech debt of reverting the replace in the future |
|
here's what dependabot raised #3270 |
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
shahar-h
force-pushed
the
GHSA-8r3f-844c-mc37
branch
from
690c659
to
afb43da
Compare
|
Fixed, you can merge either this one or #3270 |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
arkodg
approved these changes
Apr 25, 2024
zirain
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use a temporary replace directive to resolve
google.golang.org/protobufvulnerability ingoogle.golang.org/grpc/cmd/protoc-gen-go-grpcv1.3.0.This will be removed once a new release is available(see related issue).
Which issue(s) this PR fixes:
Fixes #