fix: duplicated xroutes are added to gatewayapi.Resources #3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3282 +/- ##
==========================================
+ Coverage 66.97% 67.01% +0.03%
==========================================
Files 164 166 +2
Lines 23882 23956 +74
==========================================
+ Hits 15994 16053 +59
- Misses 6964 6973 +9
- Partials 924 930 +6 ☔ View full report in Codecov by Sentry. |
|
/retest |
zirain
reviewed
May 16, 2024
Comment on lines
118
to
+128
| allAssociatedNamespaces map[string]struct{} | ||
| // Map for storing TLSRoutes' NamespacedNames attaching to various Gateway objects. | ||
| allAssociatedTLSRoutes map[string]struct{} | ||
| // Map for storing HTTPRoutes' NamespacedNames attaching to various Gateway objects. | ||
| allAssociatedHTTPRoutes map[string]struct{} | ||
| // Map for storing GRPCRoutes' NamespacedNames attaching to various Gateway objects. | ||
| allAssociatedGRPCRoutes map[string]struct{} | ||
| // Map for storing TCPRoutes' NamespacedNames attaching to various Gateway objects. | ||
| allAssociatedTCPRoutes map[string]struct{} | ||
| // Map for storing UDPRoutes' NamespacedNames attaching to various Gateway objects. | ||
| allAssociatedUDPRoutes map[string]struct{} |
There was a problem hiding this comment.
replace this with sets.set[string]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Fix duplicated TLSRoute/HTTPRoute/GRPCRoute/TCPRoute/UDPRoute are added to gatewayapi.Resources when single xRoute is attaching to multiple Gateways.
What this PR does / why we need it:
When single xRoute is attaching to multiple Gateways, this case is normal, different listeners with distinct certificates or transport sockets should route traffic to same backend. Duplicated xRoutes will be processed in
gatewayapimodule, then listener'sattachedRouteswill be incorrect.Which issue(s) this PR fixes:
Fixes #3165