feat: forward basic auth user #3312
Draft
+77
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
force-pushed
the
forward_basic_auth_username_header
branch
3 times, most recently
from
c66e1dd
to
187dec0
Compare
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
forward_basic_auth_username_header
branch
from
187dec0
to
bf20d0c
Compare
|
thoughts on |
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
…oute in a Gateway Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
zhaohuabing
commented
May 1, 2024
| @@ -24,4 +27,10 @@ type BasicAuth struct { | |||
| // | |||
| // Note: The secret must be in the same namespace as the SecurityPolicy. | |||
| Users gwapiv1b1.SecretObjectReference `json:"users"` | |||
|
|
|||
| // The name of the HTTP header that will be used to forward the username to the upstream server. | |||
| // Please note that the header name is a global setting for all the routes in a Gateway. | |||
There was a problem hiding this comment.
UserNameToHeader can also be per route, but will need some upstream work.
There was a problem hiding this comment.
imo we should wait until per route support is added, else a per route setting will enable this at the global level
There was a problem hiding this comment.
OK, let's wait for the upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts username from the HTTP authorization header and add it to a custom header, providing a user identity that can be directly used in the Authorization Policy and by other filters or backends.
Fix: #2947
Related: #2250 #2652