New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
design: Wasm extension supports OCI image code source #3313
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
I'm not sure which is a better idea:
|
Is there potential for a new component to be reused by other envoy control planes (e.g. istio)? If so, it could be beneficial from long-term maintenance perspective... Can we implement this based on some existing OCI registry cache? |
To simplify the process, I'd like to create this component as part of EG rather than a standalone binary. This will help us avoid unnecessary dependencies/management(install, upgrade,etc.) overhead.
|
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
the file content directly to response, and then close the file. There won’t be significant caching involved. | ||
However, we need to balance the memory usage and the efficiency, which could be addressed in implementation. | ||
|
||
**Caching Mechanism:** Cached files will be evicted based on LRU(Last recently used)algorithm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add more clarity here ? is there an existing registry cache we can use ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Istio wasm cache fetches wasm module from OCI registry and HTTP url, and saves them to local files. We can reuse most of this code and add an HTTP server in front.
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Related: #3304