Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics instrumentation for status updater #3347

Merged
merged 6 commits into from May 14, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented May 8, 2024

What type of PR is this?

What this PR does / why we need it:

image

Which issue(s) this PR fixes:

Fixes #2131, close #2130

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner May 8, 2024 08:57
@shawnh2 shawnh2 requested review from Xunzhuo and zirain May 8, 2024 08:57
@shawnh2
Copy link
Contributor Author

shawnh2 commented May 8, 2024

/retest

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 61.29032% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 67.06%. Comparing base (c30d09f) to head (f3ec2ab).
Report is 9 commits behind head on main.

❗ Current head f3ec2ab differs from pull request most recent head b884d83. Consider uploading reports for the commit b884d83 to get more accurate results

Files Patch % Lines
internal/provider/kubernetes/status_updater.go 61.29% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3347      +/-   ##
==========================================
- Coverage   67.11%   67.06%   -0.06%     
==========================================
  Files         164      164              
  Lines       23818    23770      -48     
==========================================
- Hits        15986    15941      -45     
  Misses       6912     6912              
+ Partials      920      917       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@Xunzhuo Xunzhuo requested a review from a team May 14, 2024 08:41
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@guydc guydc merged commit 675da4d into envoyproxy:main May 14, 2024
20 checks passed
@shawnh2 shawnh2 deleted the cp-metrics/status-updater branch May 14, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Metrics instrumentation for Status Updater
3 participants