Add control plane identifier in DiscoveryServer responses #245
+45
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
# Conflicts: # api/pom.xml # cache/pom.xml # pom.xml # server/pom.xml # server/src/main/java/io/envoyproxy/controlplane/server/V2DiscoveryServer.java # test/pom.xml
Codecov Report
@@ Coverage Diff @@
## main #245 +/- ##
============================================
+ Coverage 86.24% 86.33% +0.09%
Complexity 351 351
============================================
Files 41 41
Lines 1141 1149 +8
Branches 93 93
============================================
+ Hits 984 992 +8
Misses 112 112
Partials 45 45
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
# Conflicts: # server/src/main/java/io/envoyproxy/controlplane/server/DiscoveryServer.java # server/src/main/java/io/envoyproxy/controlplane/server/V3DiscoveryServer.java
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
Automaat
approved these changes
Oct 5, 2022
liangyuanpeng
approved these changes
Dec 27, 2022
nezdolik
approved these changes
Feb 15, 2024
|
@liangyuanpeng is this still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this task was to increase observability. With these changes, we are able to tell from which control-plane envoy gets responses.