cache: unsubscribe removed resources on reconnects #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com>
sschepens
force-pushed
the
fix-pending-resource-removal
branch
from
a8b3df6
to
154e449
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
============================================
+ Coverage 86.16% 86.24% +0.08%
- Complexity 361 363 +2
============================================
Files 42 42
Lines 1178 1178
Branches 97 97
============================================
+ Hits 1015 1016 +1
+ Misses 116 115 -1
Partials 47 47 ☔ View full report in Codecov by Sentry. |
sschepens
changed the title
sschepens
changed the title
sschepens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reconnections occur, envoy sends a new request subscribing to all the resources it currently had.
If a resource has just been removed, we fail to notify Envoy the the resource has been removed.
This happens because on the very first stream request, we dont have any
trackedResources, we should instead also checkpendingResources.