Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GHA pantsbuild/actions/init-pants #2008

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Use GHA pantsbuild/actions/init-pants #2008

wants to merge 5 commits into from

Conversation

mmorel-35
Copy link
Collaborator

No description provided.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 requested a review from phlax March 30, 2024 08:41
Copy link

netlify bot commented Mar 30, 2024

Deploy Preview for nifty-bassi-e26446 ready!

Name Link
🔨 Latest commit 533094c
🔍 Latest deploy log https://app.netlify.com/sites/nifty-bassi-e26446/deploys/6607d5167d0c3d0008cd29fc
😎 Deploy Preview https://deploy-preview-2008--nifty-bassi-e26446.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not up to date with pants workflows, but last time i looked there was a "pantsup" script and a new way of running pants (scie-pants)

i hit a bug when trying to update it (which i believe was fixed upstream) and havent had time to go back to it

wondering how this way relates to that (for ref my pr was #662)

@phlax
Copy link
Member

phlax commented Mar 30, 2024

i expected this to fail on the readme goal - which has elicited a warning - but seems to be failing on pants rules (not sure) - wondering if there is something that needs to be updated or rebuilt

@mmorel-35
Copy link
Collaborator Author

I believe an upgrade to at least 2.15 version of pants is going to be required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants