Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix babel target to es5 #330

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix babel target to es5 #330

wants to merge 2 commits into from

Conversation

ysgk
Copy link

@ysgk ysgk commented Dec 20, 2019

close #329

This PR fixes the babel target so that it works on legacy browsers.

@blainekasten
Copy link
Collaborator

@ysgk sorry for the delay here. CI seems goofed up. Going to get that re-configured before we merge

@boygirl
Copy link
Contributor

boygirl commented Dec 30, 2019

@blainekasten I just migrated a bunch of repos from gh services based travis CI to gh apps based travis CI. This PR doesn't show up in either build history. I think it may be necessary to push a fresh commit or open these changes in a new PR to trigger CI

@ljharb
Copy link
Member

ljharb commented Dec 30, 2019

@boygirl you can also manually trigger a PR build, i believe, in travis' interface

@boygirl
Copy link
Contributor

boygirl commented Dec 30, 2019

@ljharb normally I would be able to, but this branch does not show up in the buid history either on the new or old interface. It isn't that it errored, it never triggered at all.

@ljharb
Copy link
Member

ljharb commented Dec 30, 2019

@boygirl i don't mean rerun it - i mean there's a beta "trigger build" feature under "more options".

@boygirl
Copy link
Contributor

boygirl commented Dec 30, 2019

@ljharb but unfortunately this branch was never recognized by travis for whatever reason, so I am not able to trigger a build for it:

Screen Shot 2019-12-30 at 2 40 34 PM

It is not included in the list of branches for this repo
Screen Shot 2019-12-30 at 2 34 52 PM

@ysgk
Copy link
Author

ysgk commented Dec 31, 2019

I merged master. Now CI runs but fails.

https://github.com/FormidableLabs/enzyme-matchers/blob/48295d2b2730232a930125d3fc68235214261b88/packages/jest-environment-enzyme/src/index.js#L3

JSDOMEnvironment is exported from jest-environment-dom as an es6 class, so this line complains:

TypeError: Class constructor JSDOMEnvironment cannot be invoked without 'new'

I tried transformIgnorePatterns to transform jest-environment-dom, but didn't work. Are there any solutions for that?

@ysgk ysgk closed this Dec 9, 2022
@ysgk ysgk deleted the ysgk-patch-1 branch December 9, 2022 01:59
@ljharb
Copy link
Member

ljharb commented Dec 9, 2022

@ysgk it'd be really great if you could restore this branch and reopen the PR; there's still hope to merge it.

@ysgk ysgk restored the ysgk-patch-1 branch December 9, 2022 02:23
@ysgk ysgk reopened this Dec 9, 2022
@ysgk
Copy link
Author

ysgk commented Dec 9, 2022

@ljharb
OK, done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v7.1.2 is not working on IE
4 participants