Bugfix for using general sibling selector on root #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling`, `reduceTreeBySelector`
ljharb
force-pushed
the
bugfix/general_sibling_root
branch
from
b2d3d8b
to
0d446f4
Compare
|
@krawaller btw you should add the email address you used on these commits to your github account, so you can be linked to the commits. |
|
Oh, right! Done, thank you @ljharb! |
This was referenced Aug 8, 2018
This was referenced Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
.find('#foo ~ #bar')will throw an error if#foomatches the root element.This PR adds test and the missing parent check that caused the problem.