[New] shallow: setProps: add callback argument
#1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emuraton
commented
Jul 22, 2018
| @@ -1272,10 +1272,8 @@ describe('shallow', () => { | |||
| expect(wrapper.find('.foo')).to.have.lengthOf(1); | |||
|
|
|||
| wrapper[sym('__renderer__')].batchedUpdates(() => { | |||
| wrapper.setProps({ id: 'bar', foo: 'bla' }, () => { | |||
| expect(wrapper.find('.bar')).to.have.lengthOf(1); | |||
| }); | |||
There was a problem hiding this comment.
I think callback argument is not supported for ShallowRendering
https://github.com/airbnb/enzyme/blob/master/packages/enzyme/src/ShallowWrapper.js#L381
There was a problem hiding this comment.
no, but it probably should be - so that it's the same as mount
There was a problem hiding this comment.
ok, I'll update it 👍
emuraton
force-pushed
the
setProps-fix-test
branch
from
e9e6e58
to
263bd2e
Compare
emuraton
force-pushed
the
setProps-fix-test
branch
from
bd296ef
to
eba0ebc
Compare
ljharb
force-pushed
the
setProps-fix-test
branch
from
eba0ebc
to
34d69ce
Compare
ljharb
changed the title
shallow: setProps: add callback argument
This was referenced Aug 8, 2018
This was referenced Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1716