Fix to call unexpected cDM #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koba04
force-pushed
the
fix-unexpeced-cDM
branch
from
6330171
to
fb72d99
Compare
|
Looking forward to getting this released soon. |
ljharb
approved these changes
Aug 17, 2018
ljharb
force-pushed
the
fix-unexpeced-cDM
branch
from
c61f1fd
to
d2f6603
Compare
|
Incredible work! Thanks a ton! 👏👏👏 |
ljharb
pushed a commit
that referenced
this pull request
Aug 17, 2018
|
Thank you for the release!! |
This was referenced Aug 18, 2018
This was referenced Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1766. Fixes #1765.
I missed that ShallowWrapper's constructor is called when finding child components.
In this case, the
rendereris arendererof the root, which means itsinstanceis the instance of the root component. SocDMof the instance is called when creating a ShallowWrapper instance for child components.