Shallow rendering, setState after setProps calls componentWillReceiveProps #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll rebase this and tweak to use jsx, and then give it a review. |
|
Thanks for the quick response, @ljharb! Looking forward to review. 😄 |
ljharb
changed the title
ljharb
reviewed
Aug 20, 2018
| @@ -2406,6 +2406,86 @@ describe('shallow', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describeIf(is('>= 16.3'), 'should not call componentWillReceiveProps after setState is called', () => { | |||
There was a problem hiding this comment.
i changed this from is('16.3.0-0') because we want it to apply to v16.4 and later also.
Can you elaborate, though, on why this wouldn't be true for all versions of react?
|
@ljharb Thanks for rebasing as well as the additional changes! I initially used I pulled down your changes, fixed |
ljharb
approved these changes
Aug 21, 2018
ljharb
added a commit
that referenced
this pull request
Aug 21, 2018
ljharb
added a commit
that referenced
this pull request
Aug 25, 2018
- [New] Add forwardRef support (#1592, @jquense) - [New] Add Portal support (#1760, #1761, #1772, #1774, @jgzuke) - [New] Add pointer events support (#1753, @ljharb) - [Fix] preemptively fix compat with React v16.4.3 (#1790, #1778, @gaearon, @aweary) - [Fix] `shallow`: prevent rerenders with PureComponents (#1786, @koba04) - [Fix] `shallow`: skip updates when nextState is `null` or `undefined` (#1785, @koba04) - [Fix] `shallow`: `setState` after `setProps` calls `componentWillReceiveProps` (#1779, @peanutenthusiast) - [Fix] `mount`/`shallow`: be stricter on the wrapper’s setState/setProps callback - [Fix] `shallow`/`mount`: improve error message when wrapping invalid elements (#1759, @jgzuke) - update deps - [Refactor] remove most uses of lodash - [meta] ensure a license and readme is present in all packages when published
This was referenced Aug 25, 2018
This was referenced Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1746