Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for isMemo bug (#2390) #2408

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bdwain
Copy link
Contributor

@bdwain bdwain commented Jun 26, 2020

This is in response to #2390 . By throwing away the type information of the render result, we cause isMemo checks to fail on elements that have gone through the wrapper. Ideally they would pass the isMemo check

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #2408 (42d5f9e) into master (f046079) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2408   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          49       49           
  Lines        4204     4207    +3     
  Branches     1130     1130           
=======================================
+ Hits         4049     4052    +3     
  Misses        155      155           
Impacted Files Coverage Δ
...e-adapter-react-16.1/src/ReactSixteenOneAdapter.js 95.03% <0.00%> (-0.02%) ⬇️
...e-adapter-react-16.2/src/ReactSixteenTwoAdapter.js 95.09% <0.00%> (-0.02%) ⬇️
...adapter-react-16.3/src/ReactSixteenThreeAdapter.js 95.45% <0.00%> (-0.02%) ⬇️
...enzyme-adapter-react-16/src/ReactSixteenAdapter.js 95.46% <0.00%> (ø)
packages/enzyme/src/ShallowWrapper.js 99.12% <0.00%> (+<0.01%) ⬆️
packages/enzyme/src/selectors.js 96.46% <0.00%> (+0.01%) ⬆️
...nzyme-adapter-react-13/src/ReactThirteenAdapter.js 94.96% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f046079...42d5f9e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant