Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support lazy components #2521

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

support lazy components #2521

wants to merge 2 commits into from

Conversation

artola
Copy link

@artola artola commented Jun 6, 2021

Fix #2205

@codecov
Copy link

codecov bot commented Jun 6, 2021

Codecov Report

Merging #2521 (795045d) into master (41bf606) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2521      +/-   ##
==========================================
- Coverage   96.31%   95.77%   -0.54%     
==========================================
  Files          49       49              
  Lines        4207     4215       +8     
  Branches     1130     1134       +4     
==========================================
- Hits         4052     4037      -15     
- Misses        155      178      +23     
Impacted Files Coverage Δ
...enzyme-adapter-react-16/src/ReactSixteenAdapter.js 92.25% <100.00%> (-3.21%) ⬇️
...ges/enzyme-adapter-react-16/src/detectFiberTags.js 94.02% <100.00%> (+0.58%) ⬆️
...pter-react-16/src/findCurrentFiberUsingSlowPath.js 56.14% <0.00%> (-12.29%) ⬇️
packages/enzyme/src/ReactWrapper.js 99.27% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41bf606...795045d. Read the comment docs.

@artola
Copy link
Author

artola commented Jun 6, 2021

@ljharb I will appreciate your help about these test failing. I changed only enzyme-adapter-react-16 to target React v16.14.

@ljharb
Copy link
Member

ljharb commented Sep 17, 2021

@artola when i rebase this and run it locally, the tests hang - do you see the same?

@artola
Copy link
Author

artola commented Sep 23, 2021

@artola when i rebase this and run it locally, the tests hang - do you see the same?

@ljharb I also rebase, clean and install ... and tests are running with the following results:

  1061 passing (6s)
  87 pending
  57 failing

@ljharb ljharb force-pushed the master branch 3 times, most recently from 43eb75e to 39e6b1f Compare November 3, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mount Suspense and throw promise - Enzyme Internal Error: unknown node with tag 2
2 participants