Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: flatten the try catch block. #2600

Closed
wants to merge 1 commit into from
Closed

refactor: flatten the try catch block. #2600

wants to merge 1 commit into from

Conversation

mrdulin
Copy link

@mrdulin mrdulin commented Aug 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.57% ⚠️

Comparison is base (3a7701c) 96.42% compared to head (0c664aa) 95.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2600      +/-   ##
==========================================
- Coverage   96.42%   95.85%   -0.57%     
==========================================
  Files          49       43       -6     
  Lines        4332     3475     -857     
  Branches     1156      942     -214     
==========================================
- Hits         4177     3331     -846     
+ Misses        155      144      -11     

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb
Copy link
Member

ljharb commented Aug 3, 2023

Thanks! Could you explain why this is an improvement?

@mrdulin
Copy link
Author

mrdulin commented Aug 4, 2023

@ljharb Sorry, I don't know what kind of explaination you want. I think I already did. And the code explains itself.

@ljharb
Copy link
Member

ljharb commented Aug 4, 2023

Why is a flattened try/catch block better?

Neither the code, nor you, have explained that.

@mrdulin mrdulin closed this by deleting the head repository Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants