WIP: fix!: Make Set the default action

Fixes clap-rs#2687
epage · Jul 26, 2022 · 45aab30 · 45aab30
1 parent ee06707
commit 45aab30
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/builder/arg.rs b/src/builder/arg.rs
@@ -4269,9 +4269,6 @@ impl<'help> Arg<'help> {
 /// # Internally used only
 impl<'help> Arg<'help> {
     pub(crate) fn _build(&mut self) {
-        if self.is_positional() {
-            self.settings.set(ArgSettings::TakesValue);
-        }
         if self.action.is_none() {
             if self.get_id() == "help" && !self.is_takes_value_set() {
                 let action = super::ArgAction::Help;

diff --git a/src/builder/arg_settings.rs b/src/builder/arg_settings.rs
@@ -14,7 +14,7 @@ pub(crate) struct ArgFlags(Flags);
 
 impl Default for ArgFlags {
     fn default() -> Self {
-        Self::empty()
+        ArgFlags(Flags::TAKES_VAL)
     }
 }