Skip to content

Commit

Permalink
feat(derive): Start unstable-v4 feature flag
Browse files Browse the repository at this point in the history
This is split out of clap-rs#2688 as several changes I'm working on need it.
  • Loading branch information
ldm0 authored and epage committed May 6, 2022
1 parent 122b4b4 commit 91f3680
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
Expand Up @@ -112,6 +112,10 @@ jobs:
ui:
name: UI Tests
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
features: [default, next]
steps:
- name: Checkout repository
uses: actions/checkout@v3
Expand All @@ -123,7 +127,7 @@ jobs:
override: true
- uses: Swatinem/rust-cache@v1
- name: UI Tests
run: make test-ui
run: make test-ui-${{ matrix.features }}
docs:
name: Docs
runs-on: ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion Cargo.toml
Expand Up @@ -82,7 +82,8 @@ unicode = ["textwrap/unicode-width", "unicase"] # Support for unicode character
unstable-replace = []
unstable-multicall = []
unstable-grouped = []
unstable-v4 = []
# note: this will always enable clap_derive, change this to `clap_derive?/unstable-v4` when MSRV is bigger than 1.60
unstable-v4 = ["clap_derive/unstable-v4"]

[lib]
bench = false
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Expand Up @@ -33,5 +33,5 @@ test-%:
clippy-%:
cargo clippy ${_FEATURES_${@:clippy-%=%}} ${ARGS} --all-targets -- -D warnings -A deprecated

test-ui:
cargo +${MSRV} test --test derive_ui --features derive
test-ui-%:
cargo +${MSRV} test --test derive_ui --features derive ${_FEATURES_${@:test-ui-%=%}}
1 change: 1 addition & 0 deletions clap_derive/Cargo.toml
Expand Up @@ -44,6 +44,7 @@ proc-macro-error = "1"
[features]
default = []
debug = []
unstable-v4 = []

[package.metadata.docs.rs]
targets = ["x86_64-unknown-linux-gnu"]

0 comments on commit 91f3680

Please sign in to comment.