Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Panel opening after Serotonin loading #529

Conversation

NataliaDSmirnova
Copy link
Collaborator

Description

#514

  • Added checking of molecule title provided with metadata
  • If there is no title in file metadata we don't try to show it in the panel

Type of changes

  • Bug fix (non-breaking change that fixes an issue)

Checklist

  • I have read CONTRIBUTING and CODE_OF_CONDUCT guides.
  • I have followed the code style of this project.
  • I have run yarn run ci: lint and tests pass locally with my changes.
  • I have added tests that prove my fix/feature works OR The changes do not require updated tests.
  • I have added the necessary documentation OR The changes do not require updated docs.

@coveralls
Copy link

Coverage Status

coverage: 25.047% (-0.003%) from 25.05%
when pulling 9d45966 on 514-typeerror-cannot-read-properties-of-undefined-reading-join
into d3018e7 on main.

@NataliaDSmirnova NataliaDSmirnova merged commit 5c9a92e into main Mar 5, 2024
4 checks passed
@NataliaDSmirnova NataliaDSmirnova deleted the 514-typeerror-cannot-read-properties-of-undefined-reading-join branch March 5, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'join')
3 participants