Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update years in copyright #530

Merged
merged 2 commits into from Mar 7, 2024
Merged

Update years in copyright #530

merged 2 commits into from Mar 7, 2024

Conversation

NataliaDSmirnova
Copy link
Collaborator

@NataliaDSmirnova NataliaDSmirnova commented Mar 5, 2024 •
edited

Description

#512
Update a year in copyright from 2015-2023 to 2015-2024.

Checklist

  • I have read CONTRIBUTING and CODE_OF_CONDUCT guides.
  • I have followed the code style of this project.
  • I have run yarn run ci: lint and tests pass locally with my changes.
  • I have added tests that prove my fix/feature works OR The changes do not require updated tests.
  • I have added the necessary documentation OR The changes do not require updated docs.

@NataliaDSmirnova NataliaDSmirnova linked an issue Mar 5, 2024 that may be closed by this pull request
Update copyright #512
Closed
@coveralls
Copy link

coveralls commented Mar 5, 2024 •
edited

Coverage Status

coverage: 25.047%. remained the same
when pulling 3adafc3 on 512-update-copyright
into 5c9a92e on main.

paulsmirnov
paulsmirnov requested changes Mar 5, 2024
View reviewed changes
Copy link
Member

@paulsmirnov paulsmirnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for taking this task. I remember that FBXResult.js contains "2020", so we must do a flexible search. Could you check for other occurrences?

@NataliaDSmirnova
Copy link
Collaborator Author

Hi! Thanks for taking this task. I remember that FBXResult.js contains "2020", so we must do a flexible search. Could you check for other occurrences?

Good catch! Fixed.

paulsmirnov
paulsmirnov approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@paulsmirnov paulsmirnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I hope that's all :)

@NataliaDSmirnova NataliaDSmirnova merged commit 442b948 into main Mar 7, 2024
4 checks passed
@NataliaDSmirnova NataliaDSmirnova deleted the 512-update-copyright branch March 7, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulsmirnov paulsmirnov paulsmirnov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update copyright
3 participants
@NataliaDSmirnova @coveralls @paulsmirnov