-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wired up version field in AppChart #2101
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 43.54% // Head: 31.48% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2101 +/- ##
===========================================
- Coverage 43.54% 31.48% -12.07%
===========================================
Files 181 181
Lines 14603 14608 +5
===========================================
- Hits 6359 4599 -1760
- Misses 7415 9380 +1965
+ Partials 829 629 -200
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This does work but needs a change to the CRD. |
@@ -321,7 +321,7 @@ func Deploy(logger logr.Logger, parameters ChartParameters) error { | |||
} | |||
|
|||
helmChart := appChart.HelmChart | |||
helmVersion := "" | |||
helmVersion := appChart.ChartVersion | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you see this interacting with
Lines 336 to 340 in 63028b0
pieces := strings.SplitN(helmChart, ":", 2) | |
if len(pieces) == 2 { | |
helmVersion = pieces[1] | |
helmChart = pieces[0] | |
} |
IOW when the chart reference is relative to a helm repository then the version is taken from the chart reference, with actual chart and version separated by :
.
Could something similar be done with OCI references ? Assuming that OCI references can be detected as such generally.
Currently, you can't specify the needed fields to use an OCI chart as an application template:
#1485
Opening as draft since I've confirmed that the code compiles but I ran out of time to test the new functionality :(