build smaller binaries, add version subcommand #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-s -w to build smaller binaries -X options to fill in version, commit, and date
Ensures testing happens with a binary closer to what goreleaser will build.
With gzip encoding enabled it's difficult to compare content-length header because side-effects can easily break it. The test harness now automatically ignores content-length in HTTP headers unless the test fixture specifically sets an expected result.
lpmi-13
reviewed
May 13, 2024
| @@ -39,6 +39,9 @@ builds: | |||
| goarch: 386 | |||
| - goos: freebsd | |||
| goarch: arm64 | |||
| mod_timestamp: "{{ .CommitTimestamp }}" | |||
| ldflags: | |||
| - -s -w -X main.version={{.Version}} -X main.commit={{.Commit}} -X main.date={{ .CommitDate }} | |||
lpmi-13
reviewed
May 13, 2024
|
|
||
| - linker flags now contain `-s -w` to reduce binary size | ||
| - change made in build Dockerfile, goreleaser, and GH Actions | ||
| - contribution from @Ipmi-13, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR came in to add -s -w to build ldflags, which will reduce binary sizes. Since the PR only updated /Dockerfile, these will only impact locally-built binaries.
This PR adds the flags to goreleaser and github actions builds to be consistent.
Along the way I noticed that I never exposed the version information in otel-cli, so I added that too.