Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Pin sphinx to <5.1.0" #3636

Merged
merged 1 commit into from Jul 27, 2022
Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jul 26, 2022

Issue with sphinx that caused the pin was resolved in 5.1.1

This reverts commit 6e48689.

Upstream issue: sphinx-doc/sphinx#10701

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

Issue with sphinx that caused the pin was resolved in 5.1.1

This reverts commit 6e48689.
@eivindjahren eivindjahren self-assigned this Jul 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #3636 (e1f058c) into main (1d5313d) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3636      +/-   ##
==========================================
+ Coverage   64.74%   64.77%   +0.02%     
==========================================
  Files         601      601              
  Lines       46528    46528              
  Branches     4186     4186              
==========================================
+ Hits        30125    30137      +12     
+ Misses      15051    14941     -110     
- Partials     1352     1450      +98     
Impacted Files Coverage Δ
res/job_queue/forward_model_status.py 88.60% <0.00%> (-5.07%) ⬇️
libres/lib/enkf/field.cpp 0.70% <0.00%> (ø)
libres/lib/config/conf.cpp 60.47% <0.00%> (ø)
libres/lib/enkf/gen_kw.cpp 44.55% <0.00%> (ø)
libres/lib/python/init.cpp 22.58% <0.00%> (ø)
libres/lib/enkf/surface.cpp 2.59% <0.00%> (ø)
libres/lib/rms/rms_file.cpp 0.00% <0.00%> (ø)
libres/lib/enkf/enkf_obs.cpp 72.49% <0.00%> (ø)
libres/lib/enkf/gen_data.cpp 6.39% <0.00%> (ø)
libres/lib/enkf/time_map.cpp 48.32% <0.00%> (ø)
... and 39 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@eivindjahren eivindjahren enabled auto-merge (rebase) July 27, 2022 07:29
@eivindjahren eivindjahren merged commit 49f1617 into equinor:main Jul 27, 2022
@eivindjahren eivindjahren deleted the revert_pin branch July 27, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants